Skip to content

Update interface.ts to fix Angular 19 deploy #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update interface.ts to fix Angular 19 deploy #279

wants to merge 1 commit into from

Conversation

@quedicesebas
Copy link

@quedicesebas quedicesebas commented Nov 26, 2024

Fix for Angular19, should prevent 'Expected array, received object' error.

@quedicesebas
Update interface.ts
d82838e 
Fix for Angular19, should prevent 'Expected array, received object' error.
@google-cla
Copy link

google-cla bot commented Nov 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@quedicesebas quedicesebas mentioned this pull request Nov 26, 2024
Merged
@quedicesebas quedicesebas changed the title Update interface.ts Update interface.ts to fix Anular 19 deploy Nov 26, 2024
@quedicesebas quedicesebas changed the title Update interface.ts to fix Anular 19 deploy Update interface.ts to fix Angular 19 deploy Nov 26, 2024
@Yuangwang
Copy link
Collaborator

Yuangwang commented Nov 27, 2024

Copying from my comment in #277 here for visibility

For anyone running into this issue. We'll keep y'all posted on when this fix goes live. Until then please give this workaround a try:

Step 1:
In your project run npm install @apphosting/[email protected], this will install the latest adapter with this fix merged in.
After running that please verify that you see @apphosting/adapter-angular": "^17.2.11 in your package.json. Its important that the version is 17.2.11 since this fix is released with that version.

Step 2:
Add this additional line in your package.json scripts: "apphosting:build": "FRAMEWORK_VERSION=${YOUR_ANGULAR_VERSION} apphosting-adapter-angular-build"

Step 3:
Commit these changes to github and kickoff a new rollout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuangwang Yuangwang Awaiting requested review from Yuangwang Yuangwang is a code owner

@sjjj986 sjjj986 Awaiting requested review from sjjj986 sjjj986 is a code owner

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels jamesdaniels is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@blidd-google blidd-google Awaiting requested review from blidd-google blidd-google is a code owner

@taeold taeold Awaiting requested review from taeold taeold is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quedicesebas @Yuangwang